-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove restraint of vtk<9.1.0 #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 82.80% 82.81% +0.01%
==========================================
Files 26 26
Lines 1407 1408 +1
==========================================
+ Hits 1165 1166 +1
Misses 242 242 |
Windows fatal exception: access violation Thread 0x000006e8 (most recent call first): "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\site-packages\pyvista\plotting\plotting.py", line 5533 in show |
I am guessing your VTK dependency is because of PyVista right? Are you using VTK explicitly in some place? I think @akaszynski can weigh in better than anybody here. I know that VTK (as of released packages - i.e. not beta versions or release candidates) is not yet supported on Python 3.10 and they have some PyVista wheels for this specific case.. He'll probably have more info than anyone else. |
Indeed, we do not use vtk directly, only through PyVista. Here the problem is not about Python 3.10, but when using vtk==9.1.0 for Pythons 3.7 to 3.9, where we get a memory error on Windows, although I could not replicate the issue locally. |
No, what I meant was that @akaszynski provided some specific VTK wheels for 9.1.0 and Python 3.10 in the PyVista project, as far as I am aware of. Follow the link: pyvista/pyvista#2064 I am seeing though you are having problems with other Python versions now... The output on the runners is limited though. Are you getting more info locally? Or does it work just fine? Try running everything from a clean virtual env. Maybe that gives you more info on the error. Though I am sure you must have tried it already. |
This issue occurs on Windows when using the OSMesa opengl on windows. This shouldn't be an issue on linux. |
I'm going to have to review and |
We are using a pyvista github action to prepare the headless display in our CI. (pyvista/setup-headless-display-action@v1) |
Hi @akaszynski, any updates on this issue? |
On my (growing) todo list. |
Fix was simply to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM still needs to be fixed as <9.1 isn't available for Py 3.10 on Windows.
still needs to be fixed as <9.1 isn't available for Py 3.10 on Windows.
Identified the minimum reproducible error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -121,7 +121,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
python-version: ["3.8", "3.9"] | |||
python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python-version: ["3.8", "3.9", "3.10"] | |
python-version: ["3.7", "3.8", "3.9", "3.10"] |
I think that, since we are supporting above Python 3.7, shouldn't it be included in this matrix testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is tested in job Build_and_Test. We separated them to be able to trigger them independantly. The CI will however be reworked soon with a testing strategy coherent with what is being put in place for PyDPF-Core.
Tried using the same trick for doctest, yet it does not work for Python 3.10 (see here). |
Solves #107